Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: logs flags and examples #172

Merged
merged 6 commits into from
Mar 20, 2021
Merged

refactor: logs flags and examples #172

merged 6 commits into from
Mar 20, 2021

Conversation

jfatta
Copy link
Contributor

@jfatta jfatta commented Mar 19, 2021

reuse the flags helpers and added examples of the commands.

image

image

image

Widcket
Widcket reviewed Mar 19, 2021
View reviewed changes
internal/cli/logs.go Outdated Show resolved Hide resolved
Widcket
Widcket reviewed Mar 19, 2021
View reviewed changes
internal/cli/logs.go Outdated Show resolved Hide resolved
Widcket
Widcket requested changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use number as the long form of the n flag. The rest are non-blocking nits.

Widcket
Widcket approved these changes Mar 20, 2021
View reviewed changes
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Widcket Widcket merged commit 5cd6550 into main Mar 20, 2021
@Widcket Widcket deleted the refactor-logs-flags branch March 20, 2021 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfatta @Widcket