refactor: quickstarts flags #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
reviewed
Mar 19, 2021
internal/cli/quickstarts.go
Outdated
| qsWebApp = "webapp" | ||
| qsBackend = "backend" | ||
| _defaultURL = "http://localhost:3000" | ||
| clientID = Flag{ |
There was a problem hiding this comment.
Can you please prefix it with qs (qsClientID), until we move it to its own package?
Widcket
reviewed
Mar 19, 2021
internal/cli/quickstarts.go
Outdated
| IsRequired: true, | ||
| } | ||
|
|
||
| stack = Flag{ |
Widcket
reviewed
Mar 19, 2021
Widcket
reviewed
Mar 19, 2021
Widcket
reviewed
Mar 19, 2021
Co-authored-by: Rita Zerrizuela <[email protected]>
Co-authored-by: Rita Zerrizuela <[email protected]>
Co-authored-by: Rita Zerrizuela <[email protected]>
Widcket
reviewed
Mar 19, 2021
internal/cli/quickstarts.go
Outdated
| Name: "Stack", | ||
| LongForm: "stack", | ||
| ShortForm: "s", | ||
| Help: "Tech/Language of the quickstart sample to download.", |
There was a problem hiding this comment.
Shouldn't it be required as well? (prompt not withstanding)
There was a problem hiding this comment.
yes, good catch. I was honoring the previous setup but it doesn't make sense without the stack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize flags definition and usage on the
quickstartscommand.context: https://auth0team.atlassian.net/browse/CLI-77