Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove actions commands [CLI-75] #168

Merged
merged 6 commits into from
Mar 19, 2021
Merged

Remove actions commands [CLI-75] #168

merged 6 commits into from
Mar 19, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Mar 19, 2021

Description

This PR removes the actions commands, as the feature is no GA yet, and therefore subject to important changes.

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from a team March 19, 2021 17:57
Copy link
Contributor

@cyx cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean! Any docs lying around?

@Widcket
Copy link
Contributor Author

Widcket commented Mar 19, 2021

Nice and clean! Any docs lying around?

There were mocks, scopes, and logs-related logic remaining 🙈.
There are some files that can't be removed yet, as the rate-limit related logic is used by logs:

Screen Shot 2021-03-19 at 15 24 00

Screen Shot 2021-03-19 at 15 18 35

These files are the following:

@Widcket Widcket requested a review from cyx March 19, 2021 18:32
@Widcket Widcket requested a review from jfatta March 19, 2021 19:55
Copy link
Contributor

@jfatta jfatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧼 👍

@Widcket Widcket merged commit ebed1bb into main Mar 19, 2021
@Widcket Widcket deleted the remove-actions branch March 19, 2021 20:08
@cyx
Copy link
Contributor

cyx commented Mar 19, 2021

Oh yeah, good that you uncovered these skeletons. I think we can keep that part of actions since I don't think the API call to fetch an execution will change. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants