Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix passing client-id as a flag on qs download #166

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Fix passing client-id as a flag on qs download #166

merged 2 commits into from
Mar 17, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Mar 17, 2021

Description

By using !canPrompt(cmd) instead of !shouldPrompt(cmd, "client-id"), it is possible to pass the client-id as a flag:

Screen Shot 2021-03-16 at 22 07 37

Previously it resulted in an error.

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

jfatta
jfatta approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@jfatta jfatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Widcket Widcket merged commit c55d332 into main Mar 17, 2021
@Widcket Widcket deleted the fix-client-id-qs-download branch March 17, 2021 20:15
@cyx
Copy link
Contributor

cyx commented Mar 17, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfatta jfatta jfatta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Widcket @cyx @jfatta