[CLI-62] cli command to list tenants available #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfatta
reviewed
Mar 15, 2021
| return cmd | ||
| } | ||
|
|
||
| func listTenantCmd(cli *cli) *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "list", |
There was a problem hiding this comment.
I'd suggest adding the ls command alias.
There was a problem hiding this comment.
Good idea, we could alias ls all the list commands.
There was a problem hiding this comment.
do you want to create a seperate ticket for that? ls all the list commands. I will make the changes for this PR
There was a problem hiding this comment.
Yup, I'll create a ticket for that
internal/cli/tenants.go
Outdated
| return fmt.Errorf("Unable to load tenants due to an unexpected error: %w", err) | ||
| } | ||
|
|
||
| tenNames := make([]string, len(listTenant)) |
There was a problem hiding this comment.
can we move the render logic (ln34 to ln46 here) to the display package? most (all should) follow this approach. Besides consistency, it is going to apply common logic to display 1 vs several results, json output, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add a command in internal/cli/tenants.go that lists in a table the tenants available to the user:
References
https://auth0team.atlassian.net/browse/CLI-62?atlOrigin=eyJpIjoiMTlhZjY0ZTY5NTk3NDFkMjk2NjNlZjAyMDg4M2ZlNTEiLCJwIjoiaiJ9
Testing
Checklist
master