Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RS256 alg by default on new apps #160

Merged
merged 3 commits into from
Mar 15, 2021
Merged

Use RS256 alg by default on new apps #160

merged 3 commits into from
Mar 15, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Mar 12, 2021 •
edited
Loading

Description

This PR sets the alg to RS256 on app creation by default, as API2 will use HS256 otherwise.

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from cyx March 13, 2021 13:55
@Widcket Widcket merged commit 398e0e2 into main Mar 15, 2021
@Widcket Widcket deleted the rs256-default branch March 15, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyx cyx cyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @cyx