Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add enable/disable rules support to cli #16

Merged
merged 15 commits into from
Jan 26, 2021
Merged

feat: add enable/disable rules support to cli #16

merged 15 commits into from
Jan 26, 2021

Conversation

vprasanth
Copy link
Contributor

@vprasanth vprasanth commented Jan 25, 2021 •
edited
Loading

New sub-commands for rules

  • enable
  • disable

eg. auth0 rules enable --name "Empty rule"

cyx
cyx reviewed Jan 25, 2021
View reviewed changes
internal/cli/rules.go Outdated Show resolved Hide resolved
cyx
cyx reviewed Jan 25, 2021
View reviewed changes
internal/cli/rules.go Outdated Show resolved Hide resolved
@vprasanth vprasanth marked this pull request as ready for review January 25, 2021 23:06
cyx
cyx reviewed Jan 25, 2021
View reviewed changes
internal/cli/rules.go Outdated Show resolved Hide resolved
cyx
cyx reviewed Jan 25, 2021
View reviewed changes
internal/cli/rules.go Outdated Show resolved Hide resolved
cyx
cyx reviewed Jan 25, 2021
View reviewed changes
internal/cli/rules.go Outdated Show resolved Hide resolved
cyx
cyx reviewed Jan 25, 2021
View reviewed changes
internal/cli/rules.go Outdated Show resolved Hide resolved
cyx
cyx reviewed Jan 25, 2021
View reviewed changes
internal/cli/rules.go Outdated Show resolved Hide resolved
cyx
cyx reviewed Jan 26, 2021
View reviewed changes
internal/cli/rules.go Outdated Show resolved Hide resolved
cyx
cyx reviewed Jan 26, 2021
View reviewed changes
internal/cli/rules.go Outdated Show resolved Hide resolved
cyx
cyx reviewed Jan 26, 2021
View reviewed changes
internal/cli/rules.go Outdated Show resolved Hide resolved
cyx
cyx reviewed Jan 26, 2021
View reviewed changes
internal/cli/rules.go Outdated Show resolved Hide resolved
cyx
cyx reviewed Jan 26, 2021
View reviewed changes
internal/cli/rules.go Outdated Show resolved Hide resolved
cyx
cyx reviewed Jan 26, 2021
View reviewed changes
internal/cli/rules.go Outdated Show resolved Hide resolved
cyx
cyx reviewed Jan 26, 2021
View reviewed changes
internal/cli/rules.go Outdated Show resolved Hide resolved
cyx
cyx reviewed Jan 26, 2021
View reviewed changes
internal/cli/rules.go Outdated Show resolved Hide resolved
vprasanth and others added 5 commits January 25, 2021 19:18
cyx
cyx approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@cyx cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@vprasanth vprasanth merged commit c668388 into main Jan 26, 2021
@vprasanth vprasanth deleted the enable-disable-rule branch January 26, 2021 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyx cyx cyx approved these changes

@alexiskulash alexiskulash Awaiting requested review from alexiskulash

@jfatta jfatta Awaiting requested review from jfatta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vprasanth @cyx