Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split out logs into subcommands #151

Merged
merged 7 commits into from
Mar 15, 2021
Merged

Split out logs into subcommands #151

merged 7 commits into from
Mar 15, 2021

Conversation

chrisscott
Copy link
Contributor

Description

Split out logs into logs list and logs tail subcommands.

References

CLI-65
CLI-66

Testing

auth0 logs list and auth0 logs tail with optional argument [client-id] and any flags.

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from cyx March 15, 2021 17:43
cyx
cyx approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@cyx cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Did you use some other cli/pattern as an inspiration for this?

@Widcket Widcket merged commit 7d87ddb into main Mar 15, 2021
@Widcket Widcket deleted the cli-65-66-log-subcommands branch March 15, 2021 21:50
@Widcket
Copy link
Contributor

Widcket commented Mar 19, 2021

Looks good. Did you use some other cli/pattern as an inspiration for this?

https://stripe.com/docs/cli/logs/tail, https://cloud.google.com/sdk/gcloud/reference/app/logs/tail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyx cyx cyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisscott @Widcket @cyx