Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes so callers don't have to init #15

Merged
merged 2 commits into from
Jan 25, 2021
Merged

Changes so callers don't have to init #15

merged 2 commits into from
Jan 25, 2021

Conversation

cyx
Copy link
Contributor

@cyx cyx commented Jan 25, 2021 •
edited
Loading

Fixes the nil panic errors

Two problems

  1. Renderer should be ready to use so callers don't have to r.init()
  2. If the AccessToken is empty (thanks @shushen for exposing this) we should fail fast as well.

@cyx
Changes so callers don't have to init
3d2ada9 
Fixes the nil panic errors
vprasanth
vprasanth approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@vprasanth vprasanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@cyx cyx merged commit 3d2e26f into main Jan 25, 2021
@cyx cyx deleted the change-to-new-renderer branch January 25, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vprasanth vprasanth vprasanth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyx @vprasanth