Refactor string flags on apps and apis [CLI-70] #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
commented
Mar 12, 2021
| @@ -289,7 +287,7 @@ auth0 apis update <id> --name myapi | |||
| }, | |||
| } | |||
|
|
|||
| cmd.Flags().StringVarP(&inputs.Name, apiName, "n", "", "Name of the API.") | |||
| apiName.RegisterStringU(cmd, &inputs.Name) | |||
| cmd.Flags().StringVarP(&inputs.Scopes, apiScopes, "s", "", "Space-separated list of scopes.") | |||
There was a problem hiding this comment.
Scopes will be tackled on a future PR, as it needs to be changed from string flag to string slice flag, for consistency with other slice inputs
Widcket
changed the title
cyx
reviewed
Mar 13, 2021
| return ask(cmd, f, value, false) | ||
| } | ||
|
|
||
| func (f *Flag) AskU(cmd *cobra.Command, value interface{}) error { |
There was a problem hiding this comment.
It stands for "Update"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This command encapsulates and extracts the repetitive logic to define, register, configure and prompt for the value of string flags on
appsandapiscommands.Testing
Checklist
master