Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps: improve UX on create and show screens #137

Merged
merged 1 commit into from
Mar 6, 2021
Merged

Conversation

cyx
Copy link
Contributor

@cyx cyx commented Mar 6, 2021

for create / update / show, we should utilize the key value display.

Similarly, add the hint to guide the user what to do next.

$ auth0 apps create
 Name: my awesome app
 Type: Regular Web Application
 Description: dev tester
Creating application... done

=== cyx application created

  NAME           my awesome app
  TYPE           regular web application
  CLIENT ID      vXAtoaFdhlmtWjpIrjb9AUnrGEAOH2MM
  CLIENT SECRET  <redacted>

 ▸    Quickstarts: https://auth0.com/docs/quickstart/webapp
 ▸    Hint: You might wanna try `auth0 test login --client-id vXAtoaFdhlmtWjpIrjb9AUnrGEAOH2MM`

for create / update / show, we should utilize the key value display.

Similarly, add the hint to guide the user what to do next.
@cyx cyx force-pushed the apps-create-ux-improvements branch from 80bf380 to f50e97d Compare March 6, 2021 01:28
Comment on lines +112 to 123
var kvs [][]string
for _, pair := range v.KeyValues() {
k := pair[0]
v := pair[1]

// NOTE(cyx): We can either nuke it or annotate with `<none>`. For now we're choosing to nuke it.
if v != "" {
kvs = append(kvs, []string{k, v})
}
}
writeTable(r.ResultWriter, nil, kvs)
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Widcket worth noting that given we have so many empty values, I went with nuking out the empty ones to start. We can play with alternative approaches to avoiding a list of kv pairs with many null values (such as ) later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea 👍🏻

@cyx cyx merged commit 666d061 into main Mar 6, 2021
@cyx cyx deleted the apps-create-ux-improvements branch March 6, 2021 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants