Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A0CLI-21] feat: actions list #13

Merged
merged 8 commits into from
Jan 25, 2021
Merged

[A0CLI-21] feat: actions list #13

merged 8 commits into from
Jan 25, 2021

Conversation

turcottedanny
Copy link
Contributor

@turcottedanny turcottedanny commented Jan 25, 2021 •
edited
Loading

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Provides boilerplate for actions and an actions list command.

References

https://auth0team.atlassian.net/browse/A0CLI-6

Testing

go run ./cmd/auth0 actions list

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@turcottedanny turcottedanny changed the title actions list feat: actions list Jan 25, 2021
@turcottedanny turcottedanny marked this pull request as ready for review January 25, 2021 16:55
@turcottedanny turcottedanny changed the title feat: actions list [A0CLI-21] feat: actions list Jan 25, 2021
iamjem
iamjem approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@iamjem iamjem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think so long as the auth0 SDK fork you're pointing to is based off of v5.8.0 then there should be no problem merging this now. We can figure out how to get actions things upstreamed into the official SDK at the end of the project.

@turcottedanny turcottedanny merged commit 7fd930f into main Jan 25, 2021
@turcottedanny turcottedanny deleted the A0CLI-6-create-post-login-actions branch January 25, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamjem iamjem iamjem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turcottedanny @iamjem