Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quickstarts type mapping [CLI-55] #129

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Fix quickstarts type mapping [CLI-55] #129

merged 1 commit into from
Mar 5, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Mar 5, 2021 •
edited
Loading

Description

This PR fixes the mapping of the keys used to look up into the QS dictionary (that comes from quickstarts.json).
The code was using the app type as key, while the json file has the following keys:

Screen Shot 2021-03-05 at 17 43 36

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket changed the title Fix quickstarts type mapping Fix quickstarts type mapping [CLI-55] Mar 5, 2021
@Widcket Widcket merged commit 72c1a66 into main Mar 5, 2021
@Widcket Widcket deleted the fix-qs-download branch March 5, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyx cyx cyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @cyx