CLI-27: basic integration tests. #122
Conversation
the repo accidentally.
rene00
force-pushed
the
cli-27-basic-integration-tests
branch
2 times, most recently
from
4207599 to
8da4efe
Compare
rene00
force-pushed
the
cli-27-basic-integration-tests
branch
from
8da4efe to
9db1711
Compare
|
There are no github action changes included in this PR. I'm working through understanding how we can set this up safely. |
| @@ -0,0 +1,206 @@ | |||
| // auth0-cli-config-generator: A command that generates a valid config file that can be used with auth0-cli. | |||
There was a problem hiding this comment.
Thanks for these small doc touches. Makes it feel 👌
There was a problem hiding this comment.
General question on placement: should we put this in ./cmd/ instead? If not, curious to hear your thought process.
There was a problem hiding this comment.
It's only real use is to generate a config for integration testing by a CI pipeline (or a noop if a valid config exists already) so storing it outside of where it could add cognitive overhead for contributors not working on tooling for integration tests was the idea. I also wanted to ensure it didnt depend on any code within ./internal/ to keep it siloed and independent. Happy to move it to ./cmd/ and though -- just let me know.
| type config struct { | ||
| DefaultTenant string `json:"default_tenant"` | ||
| Tenants map[string]tenant `json:"tenants"` | ||
| } | ||
|
|
||
| type tenant struct { | ||
| Name string `json:"name"` | ||
| Domain string `json:"domain"` | ||
| AccessToken string `json:"access_token,omitempty"` | ||
| ExpiresAt time.Time `json:"expires_at"` | ||
| } |
There was a problem hiding this comment.
Note for the future: we can probably consider re-using some of the same entities we have in the CLI since they resemble each other.
There was a problem hiding this comment.
I made a comment on keeping it siloed but also happy to re-use entities in the CLI. I didn't want to add the coupling.
…into cli-27-basic-integration-tests
Description
Initial attempt at basic integration tests.
References
Testing
Checklist
master