Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add rules command #12

Merged
merged 4 commits into from
Jan 25, 2021
Merged

feat: add rules command #12

merged 4 commits into from
Jan 25, 2021

Conversation

vprasanth
Copy link
Contributor

  • list all rules in tenant

@vprasanth
feat: add rules command
56db5ed 
- list all rules in tenant
@vprasanth vprasanth requested review from cyx, shushen and jfatta January 25, 2021 05:29
jfatta
jfatta reviewed Jan 25, 2021
View reviewed changes
Copy link
Contributor

@jfatta jfatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 🚀
added a comment reg the JSON format

internal/display/rules.go Outdated Show resolved Hide resolved
internal/display/rules.go Outdated Show resolved Hide resolved
@vprasanth vprasanth requested a review from jfatta January 25, 2021 16:21
jfatta
jfatta approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@jfatta jfatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
minor suggestion inline 🙇

internal/display/rules.go Outdated Show resolved Hide resolved
internal/display/rules.go Outdated Show resolved Hide resolved
@cyx cyx merged commit 70b0842 into main Jan 25, 2021
@cyx cyx deleted the list-rules branch January 25, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfatta jfatta jfatta approved these changes

@cyx cyx cyx approved these changes

@shushen shushen Awaiting requested review from shushen

Assignees

@jfatta jfatta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vprasanth @cyx @jfatta