Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-18: Error messages for tenants and apis commands #118

Merged
merged 3 commits into from
Mar 3, 2021

Conversation

morganelle
Copy link
Contributor

Description

Our error style guide is writing custom error messages for errors with known causes and prefixing and passing through unknown errors.

This PR covers error messages for the tenants and apis commands.

References

https://auth0team.atlassian.net/wiki/spaces/~474568858/pages/1675758375/Auth0+CLI+DX+Proposal#Keep-error-messages-user-focused
https://auth0team.atlassian.net/jira/software/projects/CLI/boards/1063?selectedIssue=CLI-18

Testing

Tested manually.

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

Copy link
Contributor

@cyx cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for working on this!

@morganelle morganelle merged commit 66f4fd4 into main Mar 3, 2021
@morganelle morganelle deleted the error-messages branch March 3, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants