feat: brew install 🍻 #114
Merged
feat: brew install 🍻 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the provided GITHUB_TOKEN is not enough if we need to push to another repo (brew tap): https://github.com/goreleaser/goreleaser-action#limitation
jfatta
commented
Mar 7, 2021
| @@ -25,4 +25,4 @@ jobs: | |||
| version: latest | |||
| args: release --rm-dist | |||
| env: | |||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
| GITHUB_TOKEN: ${{ secrets.GORELEASER_GITHUB_TOKEN }} | |||
There was a problem hiding this comment.
this is to allow goreleaser changes on external repository https://github.com/auth0/homebrew-auth0-cli
jfatta
commented
Mar 7, 2021
| @@ -8,9 +8,11 @@ import ( | |||
|
|
|||
| func completionCmd(cli *cli) *cobra.Command { | |||
| cmd := &cobra.Command{ | |||
| Use: "completion [bash|zsh|fish|powershell]", | |||
| Use: "completion", | |||
There was a problem hiding this comment.
to align with other commands but also to keep the skip-login logic simple.
cyx
reviewed
Mar 17, 2021
Co-authored-by: Cyril David <[email protected]>
Widcket
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add homebrew release.
The tap is pushed here: https://github.com/auth0/homebrew-auth0-cli.
To install
see: https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap
Regarding formula "name":
Homebrew resolves which formula file to install and from which public repo should get it as:
auth0/homebrew-{auth0-cli}/auth0.Eventually, auth0-cli CI/CD could push its formula to homebrew-core and therefore offer the default support for brew install auth0 (it would be really nice).
Keep in mind submissions to homebrew core are not covered by goreleaser, something like this can be used: https://github.com/mislav/bump-homebrew-formula-action
see: https://docs.brew.sh/Acceptable-Formulae
TODO:
GORELEASER_GITHUB_TOKENwith an Auth0 token to push changes to the tap repo. It is currently using a personal token.Screen.Recording.2021-03-06.at.23.13.16.mov