Refactor apps [CLI-15] #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyx
reviewed
Feb 26, 2021
| @@ -265,7 +265,7 @@ auth0 apis update --id id --name myapi | |||
| cmd.Flags().StringVarP(&flags.ID, apiID, "i", "", "ID of the API.") | |||
| cmd.Flags().StringVarP(&flags.Name, apiName, "n", "", "Name of the API.") | |||
| cmd.Flags().StringVarP(&flags.Scopes, apiScopes, "s", "", "Space-separated list of scopes.") | |||
| mustRequireFlags(cmd, apiID, apiName) | |||
| mustRequireFlags(cmd, apiID) | |||
There was a problem hiding this comment.
Q: we don't need apiName because it's optional for creation?
There was a problem hiding this comment.
It's optional for update (you can update any property). For create it's required.
cyx
reviewed
Feb 26, 2021
Comment on lines
-303
to
-311
| err := ansi.Spinner("Deleting API", func() error { | ||
| return ansi.Spinner("Deleting API", func() error { | ||
| return cli.api.ResourceServer.Delete(flags.ID) | ||
| }) | ||
|
|
||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| return nil |
cyx
reviewed
Feb 26, 2021
internal/display/clients.go
Outdated
| // TODO(cyx): determine if there's a better way to filter this out. | ||
| const deprecatedAppName = "All Applications" | ||
|
|
||
| func appTypeFor(v *string) string { | ||
| func typeFor(v *string) string { |
There was a problem hiding this comment.
Given this is in the same display package scope typeFor might not make sense. If we do plan to split up packages later, it would make sense then. What do you think?
There was a problem hiding this comment.
Yes, the idea is to split it later into packages. But will change it back for now.
cyx
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
clients.gotoapps.goclientsas an aliasapps deleteapps updateso the basic CRUD is now completeapps createhttps://user-images.githubusercontent.com/5055789/109328681-7ae10100-7838-11eb-8507-ced24545b6ac.mov
apps updatehttps://user-images.githubusercontent.com/5055789/109328732-8cc2a400-7838-11eb-8380-2ef47bd8dd9c.mov
apps deletehttps://user-images.githubusercontent.com/5055789/109328803-a106a100-7838-11eb-88e3-4e691b4ed04e.mov
Testing
Checklist
master