Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rendering the settings of prompt-screen - EA #1106

Merged
merged 25 commits into from
Dec 9, 2024

Conversation

ramya18101
Copy link
Contributor

@ramya18101 ramya18101 commented Nov 25, 2024

🔧 Changes

Added support to import auth0_prompt_screen_renderer as part of the auth0 tf generate command
Add support to customize the Universal login by choosing the standard/advanced renderingMode

📚 References

This shall enable import of the resources added as part of auth0/terraform-provider-auth0#1077
To customize the UL, refer docs : https://auth0.com/docs/customize/login-pages/advanced-customizations/getting-started/configure-acul-screens

🔬 Testing

Example

auth0 tf generate --output-dir tmp-auth0-tf --resources auth0_prompt_screen_renderer
auth0 ul customize --help

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@ramya18101 ramya18101 requested a review from a team as a code owner November 25, 2024 14:13
duedares-rvj
duedares-rvj previously approved these changes Dec 9, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 16.96429% with 93 lines in your changes missing coverage. Please review.

Project coverage is 70.24%. Comparing base (fc25ffa) to head (90d95e8).

Files with missing lines Patch % Lines
internal/cli/universal_login_customize.go 8.69% 84 Missing ⚠️
internal/cli/terraform_fetcher.go 50.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1106      +/-   ##
==========================================
- Coverage   70.70%   70.24%   -0.47%     
==========================================
  Files          94       94              
  Lines       13160    13267     +107     
==========================================
+ Hits         9305     9319      +14     
- Misses       3310     3403      +93     
  Partials      545      545              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arpit-jn arpit-jn merged commit e765aec into main Dec 9, 2024
9 checks passed
@arpit-jn arpit-jn deleted the DXCDT-661-auth0Cli-support-for-prompt-screen-settings branch December 9, 2024 13:21
@duedares-rvj duedares-rvj mentioned this pull request Dec 9, 2024
2 tasks
@ramya18101 ramya18101 changed the title Add support for rendering the settings of prompt-screen Add support for rendering the settings of prompt-screen - EA Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants