-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dxcdt 586 select multiple ids for delete resource #935
Merged
m3talsmith
merged 24 commits into
main
from
DXCDT-586-select-multiple-ids-for-delete-resource
Dec 5, 2023
Merged
Dxcdt 586 select multiple ids for delete resource #935
m3talsmith
merged 24 commits into
main
from
DXCDT-586-select-multiple-ids-for-delete-resource
Dec 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [github.com/auth0/go-auth0](https://github.com/auth0/go-auth0) from 1.2.0 to 1.3.0. - [Release notes](https://github.com/auth0/go-auth0/releases) - [Changelog](https://github.com/auth0/go-auth0/blob/main/CHANGELOG.md) - [Commits](auth0/go-auth0@v1.2.0...v1.3.0) --- updated-dependencies: - dependency-name: github.com/auth0/go-auth0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix: Remove or replace deprecations for GoReleaser config Remove deprecated replacements Replace deprecated brews tap Replace deprecated scoop entries Fix name_template to reflect exact current naming conventions * DXCDT-582: Convert audience into a drop down in interactive mode in test token cmd (#906) Convert audience into a drop down in interactive mode in test token cmd * Bump github.com/auth0/go-auth0 from 1.2.0 to 1.3.0 (#908) Bumps [github.com/auth0/go-auth0](https://github.com/auth0/go-auth0) from 1.2.0 to 1.3.0. - [Release notes](https://github.com/auth0/go-auth0/releases) - [Changelog](https://github.com/auth0/go-auth0/blob/main/CHANGELOG.md) - [Commits](auth0/go-auth0@v1.2.0...v1.3.0) --- updated-dependencies: - dependency-name: github.com/auth0/go-auth0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Sergiu Ghitea <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…est token cmd (#906) Convert audience into a drop down in interactive mode in test token cmd Title Os for final release name fit
Added batch deletion to actions command Added batch deletion to apis command Added batch deletion to apps command Added batch deletion to custom domains command Added batch deletion to log streams command Added batch deletion for organizations command Added batch deletion for roles command Added batch deletion for rules command Added batch deletion for users non-interactive command Added batch deletion for user blocks non-interactive command Update required golang minimum version
* Add ability to update signing alg for apis * Removing short alias --------- Co-authored-by: Will Vedder <[email protected]>
…586-select-multiple-ids-for-delete-resource
…ct-multiple-ids-for-delete-resource
Ensure valid id before deletion process Normalize messages for deletion Remove unnecessary path escapes Continue on read failure instead of attempting delete Inform user of failed id on batch deletion Only document at most two ids likely
…ct-multiple-ids-for-delete-resource
Originally reviewed in #928 but re-opened because it was a fork and not allowing integration tests to run. |
m3talsmith
force-pushed
the
DXCDT-586-select-multiple-ids-for-delete-resource
branch
from
December 5, 2023 17:43
ae99ce0
to
3b4394d
Compare
willvedd
approved these changes
Dec 5, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #935 +/- ##
==========================================
- Coverage 72.32% 71.90% -0.42%
==========================================
Files 92 92
Lines 12503 12566 +63
==========================================
- Hits 9043 9036 -7
- Misses 2929 2990 +61
- Partials 531 540 +9 ☔ View full report in Codecov by Sentry. |
m3talsmith
deleted the
DXCDT-586-select-multiple-ids-for-delete-resource
branch
December 5, 2023 19:01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
In all the
auth0 * delete|rm
commands, we should allow users to select more than one resource to delete to improve DX📚 References
🔬 Testing
📝 Checklist