Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-601: Supporting multiple identifiers for blocks list and unblock commands #931

Merged
merged 18 commits into from
Dec 6, 2023

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Dec 1, 2023

🔧 Changes

Currently, the auth0 users blocks list and auth0 users blocks unblock commands only support user ID as the identifier. Additional identifiers were requested in #804. To address this request, this PR adds the support for email, username and phone number as identifiers for these commands in addition to the user ID.

This

📚 References

Related Issue: #804

🔬 Testing

Adding integration test cases.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@willvedd willvedd requested a review from a team as a code owner December 1, 2023 21:00
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (dba337f) 71.90% compared to head (6b78e74) 71.96%.

❗ Current head 6b78e74 differs from pull request most recent head 9dd7cac. Consider uploading reports for the commit 9dd7cac to get more accurate results

Files Patch % Lines
internal/cli/users_blocks.go 63.63% 9 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #931      +/-   ##
==========================================
+ Coverage   71.90%   71.96%   +0.05%     
==========================================
  Files          92       92              
  Lines       12566    12577      +11     
==========================================
+ Hits         9036     9051      +15     
+ Misses       2990     2983       -7     
- Partials      540      543       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@m3talsmith m3talsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only possible changes that I can see here are maybe adding some error catching (as commented on the lines).

internal/cli/users_blocks.go Outdated Show resolved Hide resolved
internal/cli/users_blocks.go Outdated Show resolved Hide resolved
internal/cli/users_blocks.go Outdated Show resolved Hide resolved
@willvedd willvedd enabled auto-merge (squash) December 6, 2023 17:08
@willvedd willvedd merged commit 4816314 into main Dec 6, 2023
8 checks passed
@willvedd willvedd deleted the DXCDT-601-users-blocks-support-identifiers branch December 6, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants