Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: mapping of multiple action secrets #844

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Sep 13, 2023

🔧 Changes

As noted by #841, when providing multiple secrets to the auth0 actions commands through the --secrets flag, only the final secret value is registered.

This can be easily observed by running the following two commands:

auth0 actions create -n multiple-secrets-test -t post-login -c "test" -s "secret1=1" -s "secret=2"
auth0 actions show <ID_FROM_CREATED_ACTION> --json

This is due to a late-binding issue when using a pointer of the loop range index and range value.

📚 References

🔬 Testing

Added unit tests. Manual verification from

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@Tenrys
Copy link
Contributor

Tenrys commented Sep 13, 2023

Tested with a build of this branch on my end, works great!

@willvedd willvedd merged commit 04fad78 into main Sep 13, 2023
@willvedd willvedd deleted the gh-851-fix-providing-multiple-action-secrets branch September 13, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants