Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-267: Consolidate auth0 add tenants into auth0 login (1/x) #546

Merged
merged 9 commits into from
Dec 9, 2022

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Dec 6, 2022

🔧 Changes

There are two ways to authenticate, either as a user or as a machine (client credentials), which is currently accomplished by auth0 login and auth0 tenants add respectively. Having two widely different commands for authenticating has been confusing and not self-documenting. In an effort to simplify the process of authenticating with an Auth0 tenant, the two commands are being consolidated into the auth0 login command.

The major difference is the addition of a --as-machine flag which will indicate to the CLI to initiate the client credentials authentication process, otherwise the command remains unchanged.

Many more improvements can be made to this command, however, the size of this PR is already fairly large, so those will be coming in a series of follow-up PRs.

📚 References

🔬 Testing

One additional integration test has been added, which will likely do for now. However, this begs the need for a more comprehensive integration testing solution that can better assert interactive behavior.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@willvedd willvedd requested a review from a team as a code owner December 6, 2022 20:28
@willvedd willvedd changed the title DXCDT-267: Consolidate auth0 add tenants into auth0 login DXCDT-267: Consolidate auth0 add tenants into auth0 login (1/2) Dec 6, 2022
internal/cli/login.go Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
internal/cli/login.go Outdated Show resolved Hide resolved
internal/cli/login.go Outdated Show resolved Hide resolved
internal/cli/login.go Outdated Show resolved Hide resolved
internal/cli/login.go Outdated Show resolved Hide resolved
internal/cli/login.go Outdated Show resolved Hide resolved
@willvedd willvedd requested review from Widcket and sergiught December 7, 2022 20:36
@willvedd willvedd changed the title DXCDT-267: Consolidate auth0 add tenants into auth0 login (1/2) DXCDT-267: Consolidate auth0 add tenants into auth0 login (1/x) Dec 7, 2022
willvedd and others added 7 commits December 9, 2022 15:30
Usage:
  auth0 tenants <operation> [parameters...] [flags]

Available Operations:
  use         Set the active tenant
  list        List your tenants [ls]
  open        Open tenant settings page in the Auth0 Dashboard

Flags:
  -h, --help   help for tenants

Global Flags:
      --debug           Enable debug mode.
      --json            Output in json format.
      --no-color        Disable colors.
      --no-input        Disable interactivity.
      --tenant string   Specific tenant to use. (default "auth0-cli-integration-tests.us.auth0.com")

Use "auth0 tenants [command] --help" for more information about a command. into
@sergiught sergiught force-pushed the DXCDT-267-consolidate-add-tenants-into-login-cmd branch from 8cff7fe to eb243cb Compare December 9, 2022 15:03
@sergiught sergiught merged commit 64f9db8 into v1 Dec 9, 2022
@sergiught sergiught deleted the DXCDT-267-consolidate-add-tenants-into-login-cmd branch December 9, 2022 15:18
willvedd added a commit that referenced this pull request Dec 21, 2022
* DXCDT-287: Remove format flag in favor of json flag (#533)

* DXCDT-288: Add perms alias for permissions subcommand (#534)

* DXCDT-286: Relegate --force flag from global context (#535)

* DXCDT-286: Hide global flags from commands when not applicable (#536)

* [1/4] DXCDT-266: Move domains subcommand one level up the hierarchy (#539)

* [2/4] DXCDT-266: Bring branding emails command under email templates (#540)

* Back-merging `main` into `v1` (#543)

DXCDT-293: Access token management for client credentials (#537)

* Storing and refreshing access token for client credentials

* Removing unnecessary comment

* Removing tenant name from being stored, removing flag declarations

* Removing tenant name from being stored

* Fixing erroneous delete

* Simplifying ExpiresAt assignment

* Remove duplicate addTenant in tenants add command

* Remove setting scopes on tenant when using client credentials

* Refactor how we check for token expiration while preparing the tenant

* Refactor cli.prepareTenant func

* Refactor cli.setup func

Co-authored-by: Will Vedder <[email protected]>
Co-authored-by: Sergiu Ghitea <[email protected]>

Co-authored-by: Will Vedder <[email protected]>
Co-authored-by: Sergiu Ghitea <[email protected]>

* [3/4] DXCDT-266: Rename branding cmd to universal-login (#541)

* [4/4] DXCDT-266: Update docs after branding command refactor (#542)

* DXCDT-283: Remove `config` command (#532)

Co-authored-by: Will Vedder <[email protected]>

* DXCDT-267: Consolidate `auth0 add tenants` into `auth0 login` (1/x) (#546)

Co-authored-by: Will Vedder <[email protected]>
Co-authored-by: Sergiu Ghitea <[email protected]>

* DXCDT-267: Graceful handling of access token regeneration (2/x) (#547)

Co-authored-by: Rita Zerrizuela <[email protected]>
Co-authored-by: Will Vedder <[email protected]>
Co-authored-by: Sergiu Ghitea <[email protected]>

* DXCDT-298: Interactive login prompt (3/x) (#551)

Co-authored-by: Rita Zerrizuela <[email protected]>
Co-authored-by: Will Vedder <[email protected]>
Co-authored-by: Sergiu Ghitea <[email protected]>
Co-authored-by: Sergiu Ghitea <[email protected]>

* DXCDT-295: Refactor quickstarts command to use quickstart meta URL (#553)

* DXCDT-297: Remove env var ingestion (#554)

Removing environment variable ingestion, removing unnecessary comment

Co-authored-by: Will Vedder <[email protected]>

* DXCDT-271: Add ci step to check that docs are up to date (#560)

* DXCDT-271: Move bundle install out of make docs and into docs-start (#562)

* DXCDT-296: Supporting additional scopes when authenticating as user (#561)

* Adding additional scopes support via --scopes flag

* Adding additional scopes support via --scopes flag

* Removing logging

* Uncommenting scope, removing Start function

* Condensing error to single line

* Fixing linting errors

* Changing test

* Updating docs

* Unpluralizing text, setting nil default value

* Fixing bad help text

* Tiny refactors on the login cmd

* Fixing linting error

* Update internal/auth/auth.go

Co-authored-by: Will Vedder <[email protected]>
Co-authored-by: Rita Zerrizuela <[email protected]>
Co-authored-by: Sergiu Ghitea <[email protected]>
Co-authored-by: Sergiu Ghitea <[email protected]>

* DXCDT-271: Fix generated docs (#563)

* Rename build_doc to doc-gen

* Downgrade json flag from persistent to local

* Update doc pages

* DXCDT-272 Add install script and update README (#564)

Co-authored-by: Will Vedder <[email protected]>
Co-authored-by: Will Vedder <[email protected]>

* DXCDT-273: Authentication documentation (#565)

Co-authored-by: Will Vedder <[email protected]>

* Updating README

* Targeting main branch before we forget to change back

Co-authored-by: Sergiu Ghitea <[email protected]>
Co-authored-by: Will Vedder <[email protected]>
Co-authored-by: Sergiu Ghitea <[email protected]>
Co-authored-by: Rita Zerrizuela <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants