Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel rule creation/update [CLI-86] #189

Closed
woloski opened this issue Mar 24, 2021 · 2 comments · Fixed by #227
Closed

Cancel rule creation/update [CLI-86] #189

woloski opened this issue Mar 24, 2021 · 2 comments · Fixed by #227
Assignees
@cyx
Labels
enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature

Comments

@woloski
Copy link

woloski commented Mar 24, 2021

Add this hint when Editor opens:

Hint: once you close the editor, the rule will be saved. To cancel, CTRL+C.
@Widcket Widcket added the enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature label Mar 24, 2021
@Widcket Widcket changed the title cancel rule creation/update Cancel rule creation/update [CLI-86] Mar 25, 2021
@Widcket
Copy link
Contributor

Widcket commented Mar 25, 2021 •
edited
Loading

Tracking on CLI-86.

@cyx cyx self-assigned this Mar 27, 2021
@cyx
Copy link
Contributor

cyx commented Mar 27, 2021

FYI I'm playing with the survey / prompt editor from the github client. If we ended up using that, we might have more steps, but also obviates the need for this.

Here's a sample @woloski:

asciicast

cyx added a commit that referenced this issue Apr 2, 2021
@cyx
Solidify editor mechanics
ee6ff7a 
I've looked into what github does, so they use a mix of this approach, and
the survey approach.

To keep it simple, we're only gonna go with the manual approach they do until
we feel the full blown prompt approach is necessary.

Closes #189
cyx added a commit that referenced this issue Apr 2, 2021
@cyx
Solidify editor mechanics
c6bec14 
I've looked into what github does, so they use a mix of this approach, and
the survey approach.

To keep it simple, we're only gonna go with the manual approach they do until
we feel the full blown prompt approach is necessary.

Closes #189
@cyx cyx mentioned this issue Apr 2, 2021
Merged
cyx added a commit that referenced this issue Apr 2, 2021
@cyx
Solidify editor mechanics
2bd1519 
I've looked into what github does, so they use a mix of this approach, and
the survey approach.

To keep it simple, we're only gonna go with the manual approach they do until
we feel the full blown prompt approach is necessary.

Closes #189
cyx added a commit that referenced this issue Apr 2, 2021
@cyx
Solidify editor mechanics
174240a 
I've looked into what github does, so they use a mix of this approach, and
the survey approach.

To keep it simple, we're only gonna go with the manual approach they do until
we feel the full blown prompt approach is necessary.

Closes #189
@cyx cyx closed this as completed in #227 Apr 2, 2021
cyx added a commit that referenced this issue Apr 2, 2021
@cyx
Solidify editor mechanics (#227)
2220ac6 
I've looked into what github does, so they use a mix of this approach, and
the survey approach.

To keep it simple, we're only gonna go with the manual approach they do until
we feel the full blown prompt approach is necessary.

Closes #189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cyx cyx

Labels
enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Solidify editor mechanics auth0/auth0-cli
3 participants
@cyx @woloski @Widcket