Skip to content

Commit

Permalink
chore: add PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
alejofernandez committed Apr 27, 2021
1 parent bcea2c2 commit c748c9e
Show file tree
Hide file tree
Showing 9 changed files with 3 additions and 272 deletions.
1 change: 0 additions & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ require (
github.com/mgutz/ansi v0.0.0-20200706080929-d51e80ef957d // indirect
github.com/mholt/archiver/v3 v3.5.0
github.com/olekukonko/tablewriter v0.0.5
github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
github.com/pierrec/lz4/v4 v4.1.3 // indirect
github.com/rivo/uniseg v0.2.0 // indirect
github.com/rjeczalik/notify v0.9.2
Expand Down
2 changes: 0 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -385,8 +385,6 @@ github.com/onsi/gomega v1.7.1/go.mod h1:XdKZgCCFLUoM/7CFJVPcG8C1xQ1AJ0vpAezJrB7J
github.com/pascaldekloe/goe v0.0.0-20180627143212-57f6aae5913c/go.mod h1:lzWF7FIEvWOWxwDKqyGYQf6ZUaNfKdP144TG7ZOy1lc=
github.com/pelletier/go-toml v1.2.0 h1:T5zMGML61Wp+FlcbWjRDT7yAxhJNAiPPLOFECq181zc=
github.com/pelletier/go-toml v1.2.0/go.mod h1:5z9KED0ma1S8pY6P1sdut58dfprrGBbd/94hg7ilaic=
github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2 h1:JhzVVoYvbOACxoUmOs6V/G4D5nPVUW73rKvXxP4XUJc=
github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2/go.mod h1:iIss55rKnNBTvrwdmkUpLnDpZoAHvWaiq5+iMmen4AE=
github.com/pierrec/lz4/v4 v4.0.3/go.mod h1:gZWDp/Ze/IJXGXf23ltt2EXimqmTUXEy0GFuRQyBid4=
github.com/pierrec/lz4/v4 v4.1.3 h1:/dvQpkb0o1pVlSgKNQqfkavlnXaIK+hJ0LXsKRUN9D4=
github.com/pierrec/lz4/v4 v4.1.3/go.mod h1:gZWDp/Ze/IJXGXf23ltt2EXimqmTUXEy0GFuRQyBid4=
Expand Down
12 changes: 3 additions & 9 deletions internal/branding/branding.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import (

"github.com/auth0/auth0-cli/internal/open"
"github.com/guiguan/caster"
"github.com/phayes/freeport"
"github.com/rjeczalik/notify"
)

Expand All @@ -36,16 +35,11 @@ func PreviewCustomTemplate(ctx context.Context, templateData TemplateData) {
ctx, cancel := context.WithCancel(ctx)
defer cancel()

address := "localhost"
port, err := freeport.GetFreePort()
if err != nil {
return
}

listener, err := net.Listen("tcp", fmt.Sprintf("%s:%d", address, port))
listener, err := net.Listen("tcp", "127.0.0.1:0")
if err != nil {
return
}
address := listener.Addr().String()

requestTimeout := 10 * time.Minute
server := &http.Server{
Expand All @@ -61,7 +55,7 @@ func PreviewCustomTemplate(ctx context.Context, templateData TemplateData) {
}
}()

err = open.URL(fmt.Sprintf("http://%s:%d/data/storybook/?path=/story/universal-login--prompts", address, port))
err = open.URL(fmt.Sprintf("http://%s/data/storybook/?path=/story/universal-login--prompts", address))
if err != nil {
return
}
Expand Down
1 change: 0 additions & 1 deletion vendor/github.com/phayes/freeport/.gitignore

This file was deleted.

134 changes: 0 additions & 134 deletions vendor/github.com/phayes/freeport/.goreleaser.yml

This file was deleted.

15 changes: 0 additions & 15 deletions vendor/github.com/phayes/freeport/LICENSE.md

This file was deleted.

58 changes: 0 additions & 58 deletions vendor/github.com/phayes/freeport/README.md

This file was deleted.

49 changes: 0 additions & 49 deletions vendor/github.com/phayes/freeport/freeport.go

This file was deleted.

3 changes: 0 additions & 3 deletions vendor/modules.txt

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit c748c9e

Please sign in to comment.