Skip to content

Commit

Permalink
chore: pin golangci-lint to v1.59.0
Browse files Browse the repository at this point in the history
  • Loading branch information
sergiught committed Jun 4, 2024
1 parent 54e9a30 commit b89db19
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 6 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,10 @@ jobs:
run: make check-docs

- name: Check for linting errors
uses: golangci/golangci-lint-action@639cd343e1d3b897ff35927a75193d57cfcba299 # [email protected]
uses: golangci/golangci-lint-action@a4f60bb28d35aeee14e6880718e0c85ff1882e64 # v6.0.1
with:
version: latest
install-mode: "goinstall"
version: 2059b18a39d559552839476ba78ce6acaa499b43 # v1.59.0
args: -v -c .golangci.yml

unit-tests:
Expand Down
8 changes: 5 additions & 3 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ run:

linters:
disable-all: true
# We are commenting a couple of them,
# so we can fix them one at a time
# as the effort is non-trivial.
enable:
- unused
- gofmt
Expand Down Expand Up @@ -36,9 +33,14 @@ linters-settings:

issues:
exclude-use-default: false
# We are excluding a couple of them,
# so we can fix them one at a time
# as the effort is non-trivial.
exclude:
- "should have a package comment"
- "package comment should be of the form"
- "should have comment"
- "be unexported"
- "blank-imports"
- "unused-parameter"
- "Error return value of (.+) is not checked"
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ $(GO_BIN)/mockgen:

$(GO_BIN)/golangci-lint:
${call print, "Installing golangci-lint"}
@go install -v github.com/golangci/golangci-lint/cmd/golangci-lint@latest
@go install -v github.com/golangci/golangci-lint/cmd/golangci-lint@2059b18a39d559552839476ba78ce6acaa499b43 # v1.59.0

$(GO_BIN)/govulncheck:
${call print, "Installing go vulnerability checker"}
Expand Down

0 comments on commit b89db19

Please sign in to comment.