DXCDT-321: Fix --no color flag (#594)

Co-authored-by: Will Vedder <[email protected]>

internal/ansi/ansi.go

@@ -29,6 +29,10 @@ var DisableColors = false
 // `CLICOLOR_FORCE`. Cf. https://bixense.com/clicolors/
 var EnvironmentOverrideColors = true
 
+// Initialize the aurora.Aurora instance. This value needs to be
+// set to prevent any runtime errors. Re-initialization of this
+// value is done later in the application lifecycle, once the
+// color configuration (ex:`--no-color`) is known.
 var color = Color()
 
 // Bold returns bolded text if the writer supports colors.
@@ -42,6 +46,14 @@ func Color() aurora.Aurora {
 	return aurora.NewAurora(shouldUseColors())
 }
 
+// Initialize re-instantiates the Aurora instance
+// This initialization step is necessary because the parsing of the
+// --no-color flag is done fairly late in the application cycle
+func Initialize(shouldDisableColors bool) {
+	DisableColors = shouldDisableColors
+	color = Color()
+}
+
 // ColorizeJSON returns a colorized version of the input JSON, if the writer
 // supports colors.
 func ColorizeJSON(json string, darkStyle bool) string {

internal/cli/root.go

@@ -84,7 +84,7 @@ func buildRootCmd(cli *cli) *cobra.Command {
 		Long:          rootShort + "\n" + getLogin(cli),
 		Version:       buildinfo.GetVersionWithCommit(),
 		PersistentPreRunE: func(cmd *cobra.Command, args []string) error {
-			ansi.DisableColors = cli.noColor
+			ansi.Initialize(cli.noColor)
 			prepareInteractivity(cmd)
 
 			// If the user is trying to login, no need to go