Skip to content

Commit

Permalink
Apply PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
sergiught committed Dec 19, 2023
1 parent 19effd1 commit 52f5e4a
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions internal/auth0/quickstart.go
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ func (q Quickstarts) FindByStack(stack string) (Quickstart, error) {
}
}

return Quickstart{}, fmt.Errorf("failed to find any quickstarts by stack: %q", stack)
return Quickstart{}, fmt.Errorf("failed to find any quickstarts for stack: %q", stack)
}

func (q Quickstarts) FilterByType(qsType string) (Quickstarts, error) {
Expand All @@ -142,7 +142,7 @@ func (q Quickstarts) FilterByType(qsType string) (Quickstarts, error) {
}

if len(filteredQuickstarts) == 0 {
return nil, fmt.Errorf("failed to find any quickstarts by type: %q", qsType)
return nil, fmt.Errorf("failed to find any quickstarts for type: %q", qsType)
}

return filteredQuickstarts, nil
Expand Down
4 changes: 2 additions & 2 deletions internal/auth0/quickstarts_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func TestFilterByType(t *testing.T) {
res, err := mockQuickStarts.FilterByType("some-unknown-type")
assert.Nil(t, res)
assert.Error(t, err)
assert.Equal(t, fmt.Sprintf("failed to find any quickstarts by type: %q", "some-unknown-type"), err.Error())
assert.Equal(t, fmt.Sprintf("failed to find any quickstarts for type: %q", "some-unknown-type"), err.Error())
})
}

Expand All @@ -68,6 +68,6 @@ func TestFindByStack(t *testing.T) {
res, err := mockQuickStarts.FindByStack("some-non-existent-qs-type")
assert.Error(t, err)
assert.Empty(t, res)
assert.Equal(t, fmt.Sprintf("failed to find any quickstarts by stack: %q", "some-non-existent-qs-type"), err.Error())
assert.Equal(t, fmt.Sprintf("failed to find any quickstarts for stack: %q", "some-non-existent-qs-type"), err.Error())
})
}
2 changes: 1 addition & 1 deletion internal/cli/log_streams.go
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ func (c *cli) logStreamPickerOptionsByType(desiredType logStreamType) pickerOpti
}
if len(options) == 0 {
return nil, fmt.Errorf(
"there are currently no log streams of type: %q, use 'auth0 logs streams create %s' to create one",
"there are currently no log streams of type: %q, use `auth0 logs streams create %s` to create one",
desiredType,
desiredType,
)
Expand Down
6 changes: 3 additions & 3 deletions internal/cli/root.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ func Execute() {

// Platform specific terminal initialization:
// this should run for all commands,
// for most of the architectures there's no requirements:.
// for most of the architectures there's no requirements.
ansi.InitConsole()

cancelCtx := contextWithCancel()
Expand Down Expand Up @@ -149,7 +149,7 @@ func addPersistentFlags(rootCmd *cobra.Command, cli *cli) {
func addSubCommands(rootCmd *cobra.Command, cli *cli) {
// The order of the commands here matters.
// Add new commands in a place that reflect its
// relevance or relation with other commands:.
// relevance or relation with other commands.
rootCmd.AddCommand(loginCmd(cli))
rootCmd.AddCommand(logoutCmd(cli))
rootCmd.AddCommand(tenantsCmd(cli))
Expand All @@ -170,7 +170,7 @@ func addSubCommands(rootCmd *cobra.Command, cli *cli) {
rootCmd.AddCommand(apiCmd(cli))
rootCmd.AddCommand(terraformCmd(cli))

// Keep completion at the bottom:.
// Keep completion at the bottom.
rootCmd.AddCommand(completionCmd(cli))
}

Expand Down
2 changes: 1 addition & 1 deletion internal/cli/terraform_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ func setupTestDIRAndImportData(t *testing.T) (string, importDataList) {
ImportID: "actionID_1",
},
{
ResourceName: "auth0_action.MyTestAction", //NOTE: duplicate name.
ResourceName: "auth0_action.MyTestAction", // NOTE: duplicate name.
ImportID: "actionID_2",
},
}
Expand Down

0 comments on commit 52f5e4a

Please sign in to comment.