-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-2139] Add errorPath configuration #84
Conversation
0b3b420
to
6d3fe59
Compare
Is the PR ready to review in that case or should we hold off? |
It is ready for review in that sense that I would love some feedback on potential edge cases that we might know that would have required the setTimeout. It looks like callback is working fine for me. But I want to make sure. Marked as draft, to avoid merging. But would appreciate your feedback #84 (comment) |
Done some more testing, should be ready to go. |
Thanks @frederikprijck! I haven't had a chance to actually test this, but it looks like it should solve #79. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Let's ensure the related issue is linked to the PR, or it is at least closed when the PR is merged.
Hi @frederikprijck - forgive me for not opening a new issue to ask this question, but do you think it would be possible to pass the The reason I ask is that I am using an Auth0 rule that prevents users from signing up using Social providers (see: https://auth0.com/rules/disable-social-signup). I can redirect them to the error URL using the changes in this PR but I cannot see a way to pass the Thank you, |
Hey @cmjacques , Before redirecting to the error path, we emit the error in the You should be able to use the Let me know if that doesn't help. |
Thanks for the very fast reply @frederikprijck - I will give it a go now. Cheers! |
Works like a charm. Thanks again @frederikprijck. All the best. |
Provide a way to configure Auth0-Angular to redirect to a custom path when an error occurs as part of the login request.