Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure interceptor uses AuthClientConfig #71

Merged
merged 2 commits into from
Oct 20, 2020
Merged

Ensure interceptor uses AuthClientConfig #71

merged 2 commits into from
Oct 20, 2020

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Oct 19, 2020 •
edited
Loading

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

The interceptor was not configured to use Auth0ClientConfig, ignoring the Dynamic configuration that was introduced in 1.1.0.

References

#70

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@frederikprijck frederikprijck requested a review from a team October 19, 2020 13:45
@frederikprijck frederikprijck mentioned this pull request Oct 19, 2020
Closed
@stevehobbsdev stevehobbsdev reopened this Oct 19, 2020
@stevehobbsdev stevehobbsdev reopened this Oct 19, 2020
@stevehobbsdev stevehobbsdev linked an issue Oct 19, 2020 that may be closed by this pull request
Unable to set httpInterceptor when providing configuration via AuthClientConfig.set #70
Closed
@stevehobbsdev stevehobbsdev reopened this Oct 19, 2020
stevehobbsdev
stevehobbsdev approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@stevehobbsdev stevehobbsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stevehobbsdev stevehobbsdev added CH: Fixed PR is fixing a bug review:small Small review labels Oct 20, 2020
@frederikprijck frederikprijck merged commit 9386a9d into master Oct 20, 2020
@frederikprijck frederikprijck deleted the fix/interceptor branch October 20, 2020 13:20
@frederikprijck frederikprijck added this to the vNext milestone Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
CH: Fixed PR is fixing a bug review:small Small review
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Unable to set httpInterceptor when providing configuration via AuthClientConfig.set
2 participants
@frederikprijck @stevehobbsdev