Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get id token claims #69

Merged
merged 8 commits into from
Oct 22, 2020
Merged

Conversation

7opf
Copy link
Contributor

@7opf 7opf commented Oct 16, 2020

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Added idTokenClaims$ observable to AuthServiece to expose the underlying getIdTokenClaims() function of auth0-spa.js in the same way as user$ observable.

Copied the user$ implementation and tests, replaced relevant bits with idTokenClaim.

Regenerated the docs with npm run build

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@7opf 7opf requested a review from a team October 16, 2020 22:02
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@7opf Please, revert the last commit as the documentation is generated as part of the release process and here is just adding noise to the diff. Someone from the team will pick up later. Thanks!

@7opf 7opf force-pushed the get_id_token_claims branch from 46f7307 to ace9df1 Compare October 19, 2020 12:52
@7opf
Copy link
Contributor Author

7opf commented Oct 19, 2020

@7opf Please, revert the last commit as the documentation is generated as part of the release process and here is just adding noise to the diff. Someone from the team will pick up later. Thanks!

OK, I've reverted. Thank you.

@stevehobbsdev
Copy link
Contributor

Thanks for this @7opf - I've rebased to master and added a commit that allows our integration tests to run with a dummy user.

Let me give it a quick test and get back to you 👍

@stevehobbsdev stevehobbsdev added the CH: Added PR is adding feature or functionality label Oct 22, 2020
@stevehobbsdev stevehobbsdev added this to the vNext milestone Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CH: Added PR is adding feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants