Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-1931] Add information regarding use inside Angular Universal projects #46

Merged
merged 1 commit into from
Sep 8, 2020
Merged

[SDK-1931] Add information regarding use inside Angular Universal projects #46

merged 1 commit into from
Sep 8, 2020

Conversation

stevehobbsdev
Copy link
Contributor

@stevehobbsdev stevehobbsdev commented Sep 8, 2020 •
edited
Loading

Description

This library does not currently have Angular Universal support, so this PR adds a small amount of guidance to the README to that effect.

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@stevehobbsdev stevehobbsdev added documentation This adds, fixes or improves documentation review:small Small review labels Sep 8, 2020
@stevehobbsdev stevehobbsdev changed the title Add information regarding use inside Angular Universal projects [SDK-1931] Add information regarding use inside Angular Universal projects Sep 8, 2020
lbalmaceda
lbalmaceda approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevehobbsdev stevehobbsdev merged commit 56f156e into master Sep 8, 2020
@stevehobbsdev stevehobbsdev deleted the docs/angular-universal branch September 8, 2020 15:31
@stevehobbsdev stevehobbsdev added this to the v1.0.0 milestone Sep 16, 2020
@stevehobbsdev stevehobbsdev added the CH: Added PR is adding feature or functionality label Sep 16, 2020
@stevehobbsdev stevehobbsdev mentioned this pull request Sep 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
CH: Added PR is adding feature or functionality documentation This adds, fixes or improves documentation review:small Small review
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stevehobbsdev @lbalmaceda