Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure allowAnonymous works with missing_refresh_token #430

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Ensure allowAnonymous works with missing_refresh_token #430

merged 1 commit into from
Feb 16, 2023

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Feb 16, 2023 •
edited
Loading

Description

Currently, allowAnonymous does not work when the SDK throws a MissingRefreshToken Error. This PR ensures the absence of a refresh token still allows requests to go through when allowAnonymous is set to true.

References

Closes #429

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@frederikprijck frederikprijck requested a review from a team as a code owner February 16, 2023 08:57
@frederikprijck frederikprijck merged commit 8a77cd4 into master Feb 16, 2023
@frederikprijck frederikprijck deleted the fix/429 branch February 16, 2023 15:09
@frederikprijck frederikprijck mentioned this pull request Mar 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AuthHttpInterceptor fails with 'allowAnonymous: true' when the error is 'missing_refresh_token'
2 participants
@frederikprijck @ewanharris