Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-1923] Improve readability of Calling an API section in the readme #42

Merged
merged 1 commit into from
Sep 7, 2020
Merged

[SDK-1923] Improve readability of Calling an API section in the readme #42

merged 1 commit into from
Sep 7, 2020

Conversation

stevehobbsdev
Copy link
Contributor

@stevehobbsdev stevehobbsdev commented Sep 3, 2020 •
edited
Loading

Description

This aims to improve the readability of the Call an API section of the readme, which was noted in the recent Angular workshop as needing improvement (lots of people missed the part where AuthHttpInterceptor had to be included).

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@stevehobbsdev stevehobbsdev added documentation This adds, fixes or improves documentation review:small Small review labels Sep 3, 2020
@stevehobbsdev stevehobbsdev merged commit 21c6db8 into master Sep 7, 2020
@stevehobbsdev stevehobbsdev deleted the fix/readme branch September 7, 2020 13:50
@stevehobbsdev stevehobbsdev added the CH: Fixed PR is fixing a bug label Sep 7, 2020
@stevehobbsdev stevehobbsdev added this to the v1.0.0 milestone Sep 16, 2020
@stevehobbsdev stevehobbsdev mentioned this pull request Sep 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
CH: Fixed PR is fixing a bug documentation This adds, fixes or improves documentation review:small Small review
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stevehobbsdev @lbalmaceda