Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-1779] AuthService creation and login methods #4

Merged
merged 5 commits into from
Jul 15, 2020
Merged

[SDK-1779] AuthService creation and login methods #4

merged 5 commits into from
Jul 15, 2020

Conversation

stevehobbsdev
Copy link
Contributor

This PR:

  • adds the AuthService class with loginWithRedirect and loginWithPopup methods, plus tests
  • defines a factory for supplying Auth0Client through dependency injection, making it easier to test
  • defines a window service so that the window object can be mocked for test

@lbalmaceda lbalmaceda merged commit ff1e9f7 into master Jul 15, 2020
@lbalmaceda lbalmaceda deleted the feature/login branch July 15, 2020 14:07
@lbalmaceda lbalmaceda added this to the v0.1.0 milestone Aug 14, 2020
@lbalmaceda lbalmaceda added the CH: Added PR is adding feature or functionality label Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
CH: Added PR is adding feature or functionality
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stevehobbsdev @lbalmaceda