-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the release pipeline #31
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
commented
Aug 13, 2020
@@ -4,7 +4,7 @@ | |||
"scripts": { | |||
"ng": "ng", | |||
"start": "ng serve", | |||
"prebuid": "npm run update-useragent", | |||
"prebuild": "npm run update-useragent", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one drove me nuts 😂
lbalmaceda
force-pushed
the
release-pipeline
branch
from
August 14, 2020 00:09
80648a3
to
ee8a5e2
Compare
stevehobbsdev
approved these changes
Aug 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good, just had a question about the changelog. Otherwise, please merge.
lbalmaceda
added
CH: Changed
PR is changing something
CH: Added
PR is adding feature or functionality
and removed
CH: Changed
PR is changing something
labels
Aug 14, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is reusing some old scripts I had around, which I refactored a bit to include the docs and user-agent update, the git tag generation.
Note that this is not going to push the changes nor do
npm publish
for us. The idea is that the diff gets a chance to be reviewed locally in case the changelog didn't pick the right items.Usage: Prepare release
v{x.y.z}
on Github.CH: xxxxx
labels in your issues or PRs, and add them to the previously created milestone.npm release {x.y.z}
and wait for it to finish.prepare/v{x.y.z}
branch againstmaster
, wait for the CI to pass, and peer approval review.master
and wait for the CI to pass again.Errors
If the generated changelog is not correct, or you used the wrong version name, you'll need to delete both the tag and the branch locally before re-running the command.
git tag -d v{x.y.z}
to delete the local tag.git branch -D prepare/{x.y.z}
to delete the local branch.npm run release:clean
to remove the temporary files, associated with the failed release.Usage: Publish to npm
npm run release:publish
.Testing
Manually
Checklist
master