Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup CI and Coverage #3

Merged
merged 5 commits into from
Jul 14, 2020
Merged

Setup CI and Coverage #3

merged 5 commits into from
Jul 14, 2020

Conversation

lbalmaceda
Copy link
Contributor

  • Add the CircleCI build file, running ng test on Node v12. Reference here.
  • Generate and upload coverage to Codecov.io
  • Add the badges to the readme file.

@lbalmaceda
Copy link
Contributor Author

lbalmaceda commented Jul 13, 2020 •
edited
Loading

Once this is merged, I'm going to configure the branch protection for master and require CI and coverage.

Edit: Coverage status check won't be possible without first authorizing the Codecov app for this org or making this repo public.

@lbalmaceda lbalmaceda merged commit 4aed729 into master Jul 14, 2020
@lbalmaceda lbalmaceda deleted the circleci-project-setup branch July 14, 2020 14:30
@lbalmaceda lbalmaceda added this to the v0.1.0 milestone Aug 14, 2020
@lbalmaceda lbalmaceda added the CH: Added PR is adding feature or functionality label Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CH: Added PR is adding feature or functionality
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@lbalmaceda