Remove Regex support from the HTTP interceptor #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehobbsdev
added
CH: Removed
|
✋ This will need to be rebased onto |
stevehobbsdev
force-pushed
the
remove-regex
branch
2 times, most recently
from
5ff24a3 to
f9a828f
Compare
stevehobbsdev
force-pushed
the
remove-regex
branch
from
ade01b0 to
4b63844
Compare
lbalmaceda
previously approved these changes
Aug 14, 2020
lbalmaceda
approved these changes
Aug 14, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the regex support from the HTTP interceptor, as there is not
a clear use case for this now that we have wildcard support.
However, this could be reversed in the future if a good use case is presented.
Also took the opportunity to add a couple interceptor URL tests that were missing, as well as checking for query strings and hashes to cover the
stripQueryFromfunction.