Improve playground with options #26
Conversation
|
A few things to talk @stevehobbsdev are around the package.json file for the playground. I'm using reactive forms and there's a special package I need to require as dependency for that, which shouldn't be part of the SDK contents. I think it would be best to create a new |
| @@ -34,6 +34,7 @@ | |||
| "@types/jasmine": "~3.5.0", | |||
| "@types/jasminewd2": "~2.0.3", | |||
| "@types/node": "^12.12.53", | |||
| "@angular/forms": "^10.0.5", | |||
There was a problem hiding this comment.
only used on the playground
| @@ -1,54 +1,83 @@ | |||
| <!-- Next Steps --> | |||
| <h1>{{ title | uppercase }}</h1> | |||
There was a problem hiding this comment.
no need to have a property for this
|
|
||
| beforeEach(async(() => { |
There was a problem hiding this comment.
no async code runs inside this
| }); | ||
|
|
||
| xit('should logout with default options', () => { | ||
| //TODO: uncheck all checkboxes |
There was a problem hiding this comment.
I understand to set up this test case we should be unchecking the option checkboxes
|
|
||
| const butLogout = compiled.querySelector('#logout'); | ||
| expect(butLogout.disabled).toBeFalse(); | ||
| //TODO: assert logout() was called without options |
There was a problem hiding this comment.
and here, check that the SDK's logout method was called
| isAuthenticated$ = this.auth.isAuthenticated$; | ||
| isLoading$ = this.auth.isLoading$; | ||
| user$ = this.auth.user$; | ||
| accessToken$ = new BehaviorSubject(null); |
There was a problem hiding this comment.
to keep the "manually" retrieved access token,
| this.auth.getAccessTokenWithPopup(), | ||
| this.auth.getAccessTokenSilently() | ||
| ) | ||
| .pipe(first()) |
There was a problem hiding this comment.
runs once and unsubscribes
| imports: [ | ||
| BrowserModule, | ||
| AppRoutingModule, | ||
| ReactiveFormsModule, |
There was a problem hiding this comment.
this one was added
|
@stevehobbsdev fixed the remaining unit tests, added the checkbox we talked about, and re-enabled the lint test command for this playground. If you're happy with the changes, good to merge |
Description
Testing
I've added unit tests for the components and some properties. There are some tests that are marked as ignored with
xituntil I find out how to modify the form on the template before calling the associated action.Checklist
masterScreenshots
Authenticated
NOT Authenticated