Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-2786] Ensure SDK works when useHash is true #215

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Sep 13, 2021

When configuring the Angular Router to use { useHash: true }, Angular's Location.path() will not include the query arguments when Auth0 redirects back to Angular as it redirects back to https://domain?code=.... instead of https://domain/#/?code=....

When we manually try navigating to https://domain/#/?code=..., our SDK processes the code and state correctly. However, when sending https://domain/#/, https://domain/# or https://domain# as the redirect_uri, Auth0 still redirects back to https://domain?code=..., making our SDK unable to process code and state.

Call to /authorize
image

Redirect sent by Auth0
image

Closes #189

@frederikprijck frederikprijck requested a review from a team as a code owner September 13, 2021 14:49
@frederikprijck frederikprijck added CH: Fixed PR is fixing a bug review:small Small review labels Sep 13, 2021
@frederikprijck frederikprijck changed the title Ensure SDK works when useHash is true [SDK-2786] Ensure SDK works when useHash is true Sep 13, 2021
@frederikprijck frederikprijck merged commit f4cc7d9 into master Sep 15, 2021
@frederikprijck frederikprijck deleted the fix/189 branch September 15, 2021 12:07
@frederikprijck frederikprijck mentioned this pull request Sep 15, 2021
@frederikprijck
Copy link
Member Author

frederikprijck commented Nov 22, 2023

Please open a new issue and include a reproduction, and I am happy to look into it. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CH: Fixed PR is fixing a bug review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth0 Login is not working with routing strategy { useHash: true } in Angular 12
3 participants