Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose internal classes and Injection Tokens #190

Merged
merged 2 commits into from
Aug 27, 2021
Merged

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Aug 9, 2021

Exposes a few extra internal classes and Injection Tokens that could be useful for people to be able to access.

Closes #183

@frederikprijck frederikprijck requested a review from a team as a code owner August 9, 2021 19:13
@frederikprijck frederikprijck added CH: Fixed PR is fixing a bug review:small Small review labels Aug 27, 2021
@frederikprijck frederikprijck merged commit dcb84a6 into master Aug 27, 2021
@frederikprijck frederikprijck deleted the fix/183 branch August 27, 2021 14:04
@schnucks-pveeramach
Copy link

Hi, Is there an ETA for when this will be available in a release? We have a use case that requires us to retrieve the id token associated with an authorize call done using the non default audience. The idTokenClaims$ observable only gets events for the default audience it looks like.

@frederikprijck
Copy link
Member Author

frederikprijck commented Sep 8, 2021

A release will most likely be done early next week, we are waiting on one fix that will go in this release.

That said, not sure this PR helps with what you are describing.

@schnucks-pveeramach
Copy link

Hmm, with the Auth0Client becoming public I was thinking we could do something like:

    this.authService.getAccessTokenSilently({
      audience: 'non default audience',
      ignoreCache: true
    }).pipe(take(1))
      .subscribe((token) => {
        auth0Client.getIdTokenClaims({ audience: 'non default audience' })
      });

Would that not be possible? If so, is there a better approach?

@frederikprijck
Copy link
Member Author

frederikprijck commented Sep 9, 2021

This PR is not making Auth0Client instance public tho.
I believe what you are asking is not possible with our Angular SDK. Could you open an issue so we can look into supporting that ?

@frederikprijck frederikprijck added this to the v1.6.1 milestone Sep 10, 2021
@frederikprijck frederikprijck mentioned this pull request Sep 10, 2021
@schnucks-pveeramach
Copy link

Sure, created: #214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CH: Fixed PR is fixing a bug review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose the auth0-angular classes for extension points
3 participants