Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Fix TSLint issues and upgrade dependencies #17

Merged
merged 4 commits into from
Jul 29, 2020

Conversation

stevehobbsdev
Copy link
Contributor

@stevehobbsdev stevehobbsdev commented Jul 28, 2020

  • Fix tslint issues
  • Update dependencies using npm update

TSLint issues ranged from:

  • missing return types
  • using angle-bracket type conversion syntax over as
  • comment lines too long
  • variable shadowing

This PR also adds a VSCode workspace file for recommending extensions for working on this project. Current recommendations include:

  • TSLint
  • Prettier

Additionally, it adds the npm run lint command to the CI build.

@@ -11,6 +11,7 @@ jobs:
- node/with-cache:
steps:
- run: npm install
- run: npm run lint -- auth0-angular
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lbalmaceda This command just runs linting on the auth0-angular project.

What do you think about running this on the playground too in the future (i.e. all projects) by just using npm run lint? I think it would be a good idea. We could change it now but there are a few linting problems on the playground currently, so maybe something to add in once you've had a chance later to have a look at them. You can see the problems locally by running npm run lint.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I saw them as well. I think running this goes a bit along with the lgtm check (missing until we make the repo public).

@lbalmaceda lbalmaceda merged commit 17790bf into master Jul 29, 2020
@lbalmaceda lbalmaceda deleted the chore/fix-issues+deps branch July 29, 2020 21:07
@lbalmaceda lbalmaceda added this to the v0.1.0 milestone Aug 14, 2020
@lbalmaceda lbalmaceda added the CH: Fixed PR is fixing a bug label Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CH: Fixed PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants