-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-2542] Expose methods from Auth0 SPA SDK #150
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but added one comment.
fe9c302
to
7390e37
Compare
Hi there. Thanks! |
@ljmcadenas That shouldn't take too long, hopefully end of this week or early next week. Out of curiosity, may I ask what is your use case for looking forward to these changes? |
@frederikprijck , sure. However, I found out this method Any better idea you might have would be much appreciated :) |
@frederikprijck @stevehobbsdev Sorry to bother you but what exactly is the workflow for using these methods supposed to look like? It's not entirely obvious from the documentation. |
@nonsenseless If you are talking about in the context of Ionic, we are working on some guidance that should be available soon. If you are talking about in the context of Angular, outside of Ionic, you shouldn't realy need these methods. |
@frederikprijck I meant specifically in the context of ionic 5 and capacitor; from the GitHub history it looks like this is something y'all are aware of and talking over but I'd definitely appreciate getting a better sense of how y'all anticipate these being used. |
@frederikprijck Actually, I may have finally slotted all the pieces together. I'll try to prepare a write-up of what was useful in my case. |
This PR exposes the following methods from Auth0 SPA SDK so that the SDK can be used
in the context of an Ionic + Capacitor app, where calling this manually is
necessary in order to be able to handle the callback at the right time:
handleRedirectCallback
buildAuthorizeUrl
buildLogoutUrl
Added unit tests for each.