[SDK-1846] Add ability to get new access tokens #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
approved these changes
Jul 27, 2020
| Injectable, | ||
| Inject, | ||
| OnDestroy, | ||
| ɵCodegenComponentFactoryResolver, |
There was a problem hiding this comment.
there's a weird symbol here. Is this intentional? 🤔
There was a problem hiding this comment.
Yeah this is a weird Angular type. The type name is correct but I don't think I need the import - will remove.
| * If an `audience` value is given to this function, the SDK always falls | ||
| * back to using an iframe to make the token exchange. | ||
| * | ||
| * Note that in all cases, falling back to an iframe requires access to |
There was a problem hiding this comment.
I assume this informational note is for samesite. Do we want to expand a bit on that or is this a copy of the react one?
There was a problem hiding this comment.
This actually refers to third-party cookie blocking in browsers like Safari and Brave, not really to do with SameSite. I've clarified that now.
There was a problem hiding this comment.
But yes - otherwise it's copied from the React SDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds wrapper methods for:
In this SDK, they are also renamed (respectively):
This is for consistency with
auth0-react.