Enable access to isLoading true state
#13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
suggested changes
Jul 22, 2020
| expect(auth0Client.handleRedirectCallback).toHaveBeenCalledTimes(1); | ||
| done(); | ||
| }); | ||
| }); | ||
|
|
||
| it('should redirect to the correct route', (done) => { | ||
| const service = TestBed.inject(AuthService); | ||
| const service = createService(); |
There was a problem hiding this comment.
lots and lots of createService(). Any reason to avoid a describe-scoped or even file-scoped beforeEach()?
describe('when some case', () => {
beforeEach(() => {
createService();
});
}There was a problem hiding this comment.
Yeah, let me revisit this. The motivation for moving it was so that the exact point of creation could be determined as a few tests need to set up something before the service is created (testing functionality that happens in the constructor), but perhaps some of that is not needed any more.
Let me clean it up a bit.
stevehobbsdev
force-pushed
the
fix/is-loading
branch
from
83de99b to
35d866f
Compare
lbalmaceda
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
isLoading$observable emission behaviour to allow access to when the value istrue. This is useful for the UI so that it can display some kind of loading spinner or text before the rest of the UI is available.This PR also does some refactoring of the tests to include a couple of helpers, but also moves the setup of the service into the
itblocks so that its creation can be controlled a bit more carefully.