Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install and configure karma-junit-reporter #11

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Conversation

stevehobbsdev
Copy link
Contributor

Description

This PR installs and configures karma-junit-reporter for better test reporting.

Is there a need for this be optimised to only run on Circle?

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@lbalmaceda
Copy link
Contributor

lbalmaceda commented Jul 21, 2020

Is there a need for this be optimised to only run on Circle?

The --no-progress should be enough. The base test command is not changing, so I don't see anything additional we need to do. If we come across something we can figure out later.

Given we don't have it enabled yet (not public repo). Did you test this locally with the circleci CLI + docker?

@stevehobbsdev stevehobbsdev merged commit 5e29889 into master Jul 21, 2020
@stevehobbsdev stevehobbsdev deleted the junit-reporter branch July 21, 2020 21:08
@lbalmaceda lbalmaceda added this to the v0.1.0 milestone Aug 14, 2020
@lbalmaceda lbalmaceda added the CH: Added PR is adding feature or functionality label Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CH: Added PR is adding feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants