Record getToken errors in the errors$ observable #104
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
Whenever
Auth0Client.getTokenSilently
orAuth0Client.getTokenWithPopup
throw an error, theAuthService
'serror$
observable will not record those errors.This PR ensures it does.
Apart from that, this PR also reworks the
AuthHttpInterceptor
to use the AuthService instead of the Auth0Client directly, to ensure errors are also recorded as part of theerror$
observable when using the interceptor.References
#103
Testing
When errors are thrown as part of either
Auth0Client.getTokenSilently
orAuth0Client.getTokenWithPopup
when callingAuthService.getAccessTokenSilently
orAuthService.getAccessTokenWithPopup
, theerror$
observable should record those errors.Checklist
master