Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed input validation [SDK-913] #620

Merged
merged 5 commits into from
Jun 18, 2020
Merged

Fixed input validation [SDK-913] #620

merged 5 commits into from
Jun 18, 2020

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Jun 16, 2020

Changes

Forgot Password Form

Submitting an empty form marked the field with red but did not display the error message.
IMG_5062
Now the error message is displayed correctly.
IMG_5060
Additionally it was allowed to submit the form with an invalid email address. This is no longer allowed.
IMG_5061

Login Form

Submitting an empty form marked the fields with red but did not display the error messages.
IMG_5063
Now the error messages are displayed correctly.
IMG_5059

Signup Form

Submitting an empty form marked the fields with red but did not display the error messages, except for the last field.
IMG_5064
Now the error messages are displayed correctly.
IMG_5056
Note that the password field has its own way to display the error message (only when it has focus).
IMG_5058

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket added this to the vNext milestone Jun 16, 2020
@Widcket Widcket requested a review from a team June 16, 2020 20:25
lbalmaceda
lbalmaceda previously approved these changes Jun 16, 2020
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note that the password field has its own way to display the error message (only when it has focus).

Definitely something we should raise to our designer to strive for that consistency.

lbalmaceda
lbalmaceda previously approved these changes Jun 17, 2020
@Widcket Widcket requested a review from lbalmaceda June 18, 2020 17:45
@lbalmaceda lbalmaceda merged commit 6686411 into master Jun 18, 2020
@lbalmaceda lbalmaceda deleted the fix/form-validation branch June 18, 2020 19:17
@Widcket Widcket mentioned this pull request Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants