Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internationalised hardcoded strings #595

Merged
merged 2 commits into from
Jan 29, 2020
Merged

Internationalised hardcoded strings #595

merged 2 commits into from
Jan 29, 2020

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Jan 29, 2020 •
edited
Loading

Changes

  • Added a string resource to the strings file.
  • Called the i18n method on two hardcoded strings.
  • Fixed a linter warning regarding the usage of reduce(true) instead of allSatisfy.

References

Closes #575.

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket requested a review from a team January 29, 2020 14:04
@Widcket Widcket added CH: Fixed tiny Tiny review labels Jan 29, 2020
@Widcket Widcket added this to the vNext milestone Jan 29, 2020
lbalmaceda
lbalmaceda approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember checking if these were the only usages of those strings across the project. LGTM

@Widcket Widcket merged commit 98e7a61 into master Jan 29, 2020
@Widcket Widcket deleted the fix/hardcoded-strings branch January 29, 2020 14:16
@Widcket Widcket mentioned this pull request Feb 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
CH: Fixed tiny Tiny review
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.

Multi language does not work properly
2 participants
@Widcket @lbalmaceda