Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Email validation to allow uppercase characters #551

Merged
merged 1 commit into from
May 7, 2019
Merged

Update Email validation to allow uppercase characters #551

merged 1 commit into from
May 7, 2019

Conversation

cocojoe
Copy link
Member

@cocojoe cocojoe commented May 7, 2019

Update tests

Changes

Allow uppercase characters in Email e.g. [email protected]

References

Internal

Testing

Updated

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@cocojoe cocojoe requested a review from a team May 7, 2019 13:10
lbalmaceda
lbalmaceda approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cocojoe cocojoe merged commit 1d07d9b into master May 7, 2019
@cocojoe cocojoe deleted the updated-email-validation branch May 7, 2019 13:48
@cocojoe cocojoe added this to the 2.10.1 milestone May 7, 2019
@cocojoe cocojoe mentioned this pull request May 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
CH: Changed
Projects
None yet
Milestone
2.10.1
Development

Successfully merging this pull request may close these issues.
2 participants
@cocojoe @lbalmaceda